SelectOption: Add method getLabel() and change method setLabel()

[sukhwinder33445]

This PR allows to easily get the label of the selected option. getContect() returns an array of ValidHtml[] and makes it harder to get the label as string.

Usage:

$form->getElement('user')->getOption($form->getValue('user'))->getLabel()

[nilmerg]

Please rebase here, there's a new test covering this change.

[lippserd]

What is the purpose of this PR, i.e. why do you have to change the label after construction? Also, there's setContent() and getContent() which could just be used on the element.

[sukhwinder33445]

I noticed that label can be null in the constructor. It makes no sense to have an option without label. Maybe this should be fixed in a separate PR.

[lippserd]

What is the purpose of this PR, i.e. why do you have to change the label after construction? Also, there's setContent() and getContent() which could just be used on the element.

So you have updated the description. I suppose now it's just a matter of getLabel(). What do you want do with the label?

[lippserd]

I noticed that label can be null in the constructor. It makes no sense to have an option without label. Maybe this should be fixed in a separate PR.

We'll talk about that later. option can be used in several places and here and there it applies to have no value. For a select option, of course, this makes no sense. However, value could be empty, which then defaults to the content. I will create an issue for all this later. First, I want to understand what you want to do with the label.

[lippserd]

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option

[sukhwinder33445]

What is the purpose of this PR, i.e. why do you have to change the label after construction? Also, there's setContent() and getContent() which could just be used on the element.

So you have updated the description. I suppose now it's just a matter of getLabel(). What do you want do with the label?

I have a use case for getLabel() in PartnerPortal.
I want to get the name of the customer (name = label, value = id) of the selected option. So $form->getElement('user')->getOption($form->getValue('user'))->getLabel() helps me to do that.

[lippserd]

@sukhwinder33445 This can be closed, right?

[lippserd]

@sukhwinder33445 This can be closed, right?

Talked with @nilmerg about this. I'll review the PR and we add it (maybe 😆).

[lippserd]

In addition to the requested changes, setLabel() must NOT be removed, see here for a usage example.

I would like to see the following tests:

• testRendering
• testRenderingAfterSetLabel
• testGetLabel
• testGetLabelAfterSetLabel

[nilmerg]

As we're changing this so fundamentally, may I ask what the purpose of a SelectOption without a value is? Once constructed, it's not possible to change it, so if not passed to the constructor, the value is permanently not set.
I'd also question that the label may not be set. What's the purpose of a SelectOption without a label?

[lippserd]

As we're changing this so fundamentally, may I ask what the purpose of a SelectOption without a value is? Once constructed, it's not possible to change it, so if not passed to the constructor, the value is permanently not set. I'd also question that the label may not be set. What's the purpose of a SelectOption without a label?

null is already used as value: https://github.com/Icinga/icingaweb2-module-vspheredb/blob/master/library/Vspheredb/Web/Form/InfluxDbConnectionForm.php#L60

Not having a label is questionable though.

outdated