Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actiontable.js: Use event.currentTarget instead of the closest tr #3299

Merged

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jan 22, 2018

This event is triggered due to delegation. If any onclick event is able to bubble up this far that it gets triggered we can safely use whatever it has been triggered for. (i.e. it can only be a tr[href])

fixes #3298

@nilmerg nilmerg added this to the 2.5.1 milestone Jan 22, 2018
@nilmerg nilmerg requested a review from lippserd January 22, 2018 09:54
This event is triggered due to delegation. If any onclick event is able
to bubble up this far that it gets triggered we can safely use whatever
it has been triggered for. (i.e. it can only be a tr[href])

refs #3298
@nilmerg nilmerg force-pushed the bugfix/html-in-plugin-output-leads-to-js-errors-3298 branch from eb1ab1d to 7483a16 Compare January 22, 2018 12:29
@nilmerg
Copy link
Member Author

nilmerg commented Jan 22, 2018

@lippserd Commit and pull request updated.

Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Johannes.

@lippserd lippserd merged commit ac848fd into master Jan 22, 2018
@lippserd lippserd deleted the bugfix/html-in-plugin-output-leads-to-js-errors-3298 branch January 22, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML in the first line of plugin output may lead to JS errors
2 participants