Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icinga DB: Change ID fields to match SQL schema #8764

Merged
merged 1 commit into from
May 20, 2021
Merged

Icinga DB: Change ID fields to match SQL schema #8764

merged 1 commit into from
May 20, 2021

Conversation

N-o-X
Copy link
Contributor

@N-o-X N-o-X commented May 18, 2021

This PR replaces the ID fields object_id and group_id with {typeName}_id and {typeName}group_id to better mach the SQL schema.

@N-o-X N-o-X added the area/icingadb New backend label May 18, 2021
@icinga-probot icinga-probot bot added this to the 2.13.0 milestone May 18, 2021
@N-o-X N-o-X requested a review from Al2Klimov May 19, 2021 07:29
Al2Klimov
Al2Klimov requested changes May 19, 2021
View reviewed changes
lib/icingadb/icingadb-objects.cpp Outdated Show resolved Hide resolved
lib/icingadb/icingadb-objects.cpp Outdated Show resolved Hide resolved
lib/icingadb/icingadb-objects.cpp Show resolved Hide resolved
@N-o-X N-o-X force-pushed the bugfix/icingadb-change-id-fields-to-match-sql-schema branch from b9d36a2 to 898e7fd Compare May 19, 2021 15:01
@N-o-X N-o-X requested a review from Al2Klimov May 19, 2021 15:02
Al2Klimov
Al2Klimov approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N-o-X N-o-X merged commit 8150b06 into master May 20, 2021
@Al2Klimov Al2Klimov deleted the bugfix/icingadb-change-id-fields-to-match-sql-schema branch May 26, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al2Klimov Al2Klimov Al2Klimov approved these changes

Assignees
No one assigned
Labels
area/icingadb New backend
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@N-o-X @Al2Klimov