Dependency: track all relationships via DependencyGraph

[Al2Klimov]

... to ensure dependencies get deleted via cascade=1.

fixes #8180

[Al2Klimov]

Before

After

➜  icinga2 git:(bugfix/deleting-service-cascade-1-dependencies-8180) curl -fksSLu root:icinga -H 'Accept: application/json' -X GET 'https://localhost:5665/v1/objects/dependencies/lolcat2!rofl!mew' -d '{ "pretty": true }'; echo

curl: (22) The requested URL returned error: 404 Not Found

➜  icinga2 git:(bugfix/deleting-service-cascade-1-dependencies-8180) curl -fksSLu root:icinga -H 'Accept: application/json' -X GET 'https://localhost:5665/v1/objects/dependencies/lolcat2!rofl!lolcat' -d '{ "pretty": true }'; echo

curl: (22) The requested URL returned error: 404 Not Found

➜  icinga2 git:(bugfix/deleting-service-cascade-1-dependencies-8180)

[shaikatz]

Hi, any updates on that? looking forward to seeing that merged.

[julianbrost]

I think there was just a typo (or copy paste mistake) in the old code, see inline comment. Fixing this should suffice, other places use the very same method to track dependencies, see for example comment.ti:

icinga2/lib/icinga/comment.ti

Lines 37 to 61 in ca52366

	[config, protected, required, navigation(host)] name(Host) host_name {
	navigate {{{
	return Host::GetByName(GetHostName());
	}}}
	};
	[config, protected, navigation(service)] String service_name {
	track {{{
	if (!oldValue.IsEmpty()) {
	Service::Ptr service = Service::GetByNamePair(GetHostName(), oldValue);
	DependencyGraph::RemoveDependency(this, service.get());
	}
	if (!newValue.IsEmpty()) {
	Service::Ptr service = Service::GetByNamePair(GetHostName(), newValue);
	DependencyGraph::AddDependency(this, service.get());
	}
	}}}
	navigate {{{
	if (GetServiceName().IsEmpty())
	return nullptr;
	Host::Ptr host = Host::GetByName(GetHostName());
	return host->GetServiceByShortName(GetServiceName());
	}}}
	};

So if there's something wrong in general with how tracking of service dependencies works right now, there are more places where this should be changes. But I think the current way works fine apart from the typo in the tracking code for Dependency.child_service_name.

Note that there is no tracking explicitly specified, this is implicitly generated (there is ObjectImpl<Comment>::TrackHostName in comment-ti.cpp for example).

[julianbrost]

I think the root cause for the related issue is that it should say GetChildHostName() here and in line 40.