Only create downtimes from non-paused ScheduledDowntime objects in HA enabled cluster zones #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled cluster zones
SDs paused
Downtimes just once
|
|
@dnsmichi What if my config master doesn't accept config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a discussion with @Al2Klimov we came to the conclusion that
a ScheduledDowntime "does something" in HA enabled cluster zones,
similar to Checkable and Notification objects. As such, they can
be balanced.
Since we already have the HA & UpdateObjectAuthority functionality
available, we just need to ensure that only the active SD object
calls
CreateNextDowntime()thus leaving the paused SD object"doing nothing".
That way generated downtimes from SD objects only happen once,
and the cluster syncs just that one downtime to both nodes.
No more duplicates, tests attached.
fixes #2844