Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sysconfig file detection for Icinga 2 settings #6241

Merged
merged 3 commits into from
Apr 19, 2018
Merged

Fix Sysconfig file detection for Icinga 2 settings #6241

merged 3 commits into from
Apr 19, 2018

Conversation

dnsmichi
Copy link
Contributor

fixes #6215

Michael Friedrich and others added 3 commits April 19, 2018 08:55
Fix SysconfigFile detection for binary builds
a45dba1 
It may happen that the variable is not properly initialized
and we'll have an empty string. Observed on macOS and inside
Docker.

refs #6215
@Crunsher
Add improved error messages for resource limits
8b01264 
refs #6215
Log warning when sysconfig file cannot be read
e6f214f 
refs #6215
@dnsmichi dnsmichi requested a review from Crunsher April 19, 2018 08:11
@dnsmichi dnsmichi added this to the 2.8.3 milestone Apr 19, 2018
@dnsmichi dnsmichi added bug Something isn't working area/setup Installation, systemd, sample files labels Apr 19, 2018
@Crunsher Crunsher merged commit 3c4085b into master Apr 19, 2018
@Crunsher Crunsher deleted the fix/sysconfig-location-ignored branch April 19, 2018 09:17
dnsmichi pushed a commit that referenced this pull request Apr 19, 2018
Fix SysconfigFile detection for binary builds
0d26a2b 
It may happen that the variable is not properly initialized
and we'll have an empty string. Observed on macOS and inside
Docker.

refs #6215

refs #6241
dnsmichi pushed a commit that referenced this pull request Apr 19, 2018
@Crunsher
Add improved error messages for resource limits
978d707 
refs #6215

refs #6241
dnsmichi pushed a commit that referenced this pull request Apr 19, 2018
Log warning when sysconfig file cannot be read
bd2c266 
refs #6215

refs #6241
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Apr 19, 2018
@Crunsher Crunsher mentioned this pull request Apr 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crunsher Crunsher Crunsher approved these changes

Assignees
No one assigned
Labels
area/setup Installation, systemd, sample files backported Fix was included in a bugfix release bug Something isn't working
Projects
None yet
Milestone
2.8.3
Development

Successfully merging this pull request may close these issues.

Sysconfig limits and settings are not respected
2 participants
@dnsmichi @Crunsher