Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect socket handling for the HTTP client #5760

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Fix incorrect socket handling for the HTTP client #5760

merged 1 commit into from
Dec 8, 2017

Conversation

gunnarbeutner
Copy link
Contributor

This fixes a number of issues with the HTTP client:

  • Icinga might crash with some HTTP/1.0 responses.
  • HttpResponse::Parse has an incorrect return value in some cases (especially for blocking mode).
  • StreamReadContext::FillFromStream might call Read() for a stream that is already closed.

@gunnarbeutner gunnarbeutner added bug Something isn't working core/crash Shouldn't happen, requires attention labels Nov 15, 2017
@gunnarbeutner gunnarbeutner added this to the 2.9.0 milestone Nov 15, 2017
@gunnarbeutner gunnarbeutner mentioned this pull request Nov 15, 2017
Merged
@dnsmichi dnsmichi merged commit a72a7b7 into master Dec 8, 2017
@gunnarbeutner gunnarbeutner modified the milestones: 2.9.0, 2.8.1 Dec 12, 2017
@gunnarbeutner
Copy link
Contributor Author

Backported into support/2.8.

@Crunsher Crunsher deleted the fix/http-client-bugs branch December 15, 2017 10:23
@dnsmichi dnsmichi mentioned this pull request Jan 16, 2018
Merged
@dnsmichi dnsmichi modified the milestones: 2.8.1, 2.9.0 Jan 16, 2018
@dnsmichi
Copy link
Contributor

We agreed on reverting this from the 2.8.x as the InfluxDBWriter performance fixes require more reliable and long-term tests. Such changes will only hit master and 2.9 then.

Required reverts:

#5759
#5760 [x]
#5764

dnsmichi pushed a commit that referenced this pull request Jan 16, 2018
Revert "Fix incorrect socket handling for the HTTP client"
c3fe1a6 
This reverts commit 59da943.

refs #5760
@N-o-X N-o-X modified the milestones: 2.9.0, 2.8.2 Jan 17, 2018
@N-o-X N-o-X added the backported Fix was included in a bugfix release label Jan 18, 2018
@dnsmichi dnsmichi mentioned this pull request Jan 18, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
backported Fix was included in a bugfix release bug Something isn't working core/crash Shouldn't happen, requires attention
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gunnarbeutner @dnsmichi @N-o-X