Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Don't disconnect API clients (HTTP) automatically (after 10s) #5008

Closed
wants to merge 1 commit into from
Closed

WIP: Don't disconnect API clients (HTTP) automatically (after 10s) #5008

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

fixes #4968

@dnsmichi dnsmichi added the area/api REST API label Feb 20, 2017
@dnsmichi dnsmichi added the needs feedback We'll only proceed once we hear from you again label Mar 10, 2017
@dnsmichi
Copy link
Contributor

dnsmichi commented May 9, 2017

Unfortunately the proposed fix does not entirely solve the issue.

@Al2Klimov
Copy link
Member Author

Does the error still occur?

@dnsmichi dnsmichi changed the title Don't disconnect API clients (HTTP) automatically (after 10s) WIP: Don't disconnect API clients (HTTP) automatically (after 10s) Jun 16, 2017
@Stefar77
Copy link
Contributor

Stefar77 commented Jul 17, 2017

Try with #5419

Making the timeout a config setting may be an idea.
edit;
Set mine to 1 hour;
`after more waiting it seems stable at 40 threads, I think the Netscaler montitor does keep-alive and my phone just sometimes is very slow closing connections.

Going to keep testing but I think the entire timer may be removed indeed.

@dnsmichi dnsmichi removed the needs feedback We'll only proceed once we hear from you again label Sep 25, 2017
@dnsmichi
Copy link
Contributor

Entirely removing the timeout isn't an option here. Since this is what this patch is all about, I'm closing this in favor of a better solution to be discussed in #5148 and so on.

@dnsmichi dnsmichi closed this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API breaks JSON on large result
3 participants