Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.11 rc1: built-in check command "icinga" doesn't work with version compare #7415

Closed
stevie-sy opened this issue Aug 13, 2019 · 4 comments · Fixed by #7418
Closed

2.11 rc1: built-in check command "icinga" doesn't work with version compare #7415

stevie-sy opened this issue Aug 13, 2019 · 4 comments · Fixed by #7418
Assignees
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Milestone

Comments

@stevie-sy
Copy link
Contributor

Describe the bug

At our test Cluster (2 master, 4 satellite in 2 zones) the built-in check command "icinga" with the performance-data doen't work like before:
image
this error we got on every node.

To Reproduce

define the build in check-command "icinga" on the icinga Server and after a check you get this message.

Expected behavior

The check should work like before. e.g. 2.10.5
image

BTW: Other built-in check commands like "ido", "cluster" work like before.

Your Environment

Include as many relevant details about the environment you experienced the problem in

  • Version used (icinga2 --version): 2.11.0-0.rc1.1
  • Operating System and version: CentOS 7.6.1810
@dnsmichi
Copy link
Contributor

Try removing icinga_min_version while testing the RC with a different version format. Seems the version detector needs a fix in there for "abnormal" versions.

@dnsmichi dnsmichi self-assigned this Aug 13, 2019
@dnsmichi dnsmichi added the area/configuration DSL, parser, compiler, error handling label Aug 13, 2019
@stevie-sy
Copy link
Contributor Author

stevie-sy commented Aug 13, 2019

perfect, that's it . Whithout the variable "icinga_min_version" it works like before.

@dnsmichi dnsmichi added the bug Something isn't working label Aug 13, 2019
@dnsmichi
Copy link
Contributor

Only happens with the RC packages, with a specific version.

[root@icinga2 demo]# icinga2 console --connect 'https://root:icinga@localhost:5665/'
Icinga 2 (version: 2.11.0-0.rc1.1)
Type $help to view available commands.

<7> => System.ApplicationVersion
"2.11.0-0.rc1.1"

Screen Shot 2019-08-13 at 17 37 52

@dnsmichi dnsmichi changed the title 2.11 rc1: built-in check command "icinga" doesn't work 2.11 rc1: built-in check command "icinga" doesn't work with version compare Aug 13, 2019
@dnsmichi dnsmichi added this to the 2.11.0 milestone Aug 13, 2019
@dnsmichi dnsmichi mentioned this issue Aug 13, 2019
54 tasks
@dnsmichi
Copy link
Contributor

Fixed this in the proper way with using regex and adding unit tests for all functions involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants