Return 500 when no api action is successful

fixes #5095
Icinga · Apr 5, 2018 · a9c6089 · a9c6089
1 parent e08231f
commit a9c6089
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/remote/actionshandler.cpp b/lib/remote/actionshandler.cpp
@@ -91,11 +91,19 @@ bool ActionsHandler::HandleRequest(const ApiUser::Ptr& user, HttpRequest& reques
 		}
 	}
 
+	response.SetStatus(500, "No action executed successfully");
+
+	for (const Dictionary::Ptr& res : results) {
+		if (!res->Contains("result") && res->Get("result") == 200) {
+			response.SetStatus(200, "OK");
+			break;
+		}
+	}
+
 	Dictionary::Ptr result = new Dictionary({
 		{ "results", new Array(std::move(results)) }
 	});
 
-	response.SetStatus(200, "OK");
 	HttpUtility::SendJsonBody(response, params, result);
 
 	return true;