Fix 100% CPU usage issue and incorrect pending checks accounting in C…

…heckerComponent::CheckThreadProc fixes #11806
Icinga · May 19, 2016 · 232c299 · 232c299
1 parent 597d1c3
commit 232c299
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/checker/checkercomponent.cpp b/lib/checker/checkercomponent.cpp
@@ -121,7 +121,10 @@ void CheckerComponent::CheckThreadProc(void)
 
 		double wait = checkable->GetNextCheck() - Utility::GetTime();
 
-		if (wait > 0 || Checkable::GetPendingChecks() >= GetConcurrentChecks()) {
+		if (Checkable::GetPendingChecks() >= GetConcurrentChecks())
+			wait = 0.5;
+
+		if (wait > 0) {
 			/* Wait for the next check. */
 			m_CV.timed_wait(lock, boost::posix_time::milliseconds(wait * 1000));
 

diff --git a/lib/methods/pluginchecktask.cpp b/lib/methods/pluginchecktask.cpp
@@ -52,11 +52,12 @@ void PluginCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckRes
 	resolvers.push_back(std::make_pair("command", commandObj));
 	resolvers.push_back(std::make_pair("icinga", IcingaApplication::GetInstance()));
 
-	Checkable::IncreasePendingChecks();
-
 	PluginUtility::ExecuteCommand(commandObj, checkable, checkable->GetLastCheckResult(),
 	    resolvers, resolvedMacros, useResolvedMacros,
 	    boost::bind(&PluginCheckTask::ProcessFinishedHandler, checkable, cr, _1, _2));
+
+	if (!resolvedMacros || useResolvedMacros)
+		Checkable::IncreasePendingChecks();
 }
 
 void PluginCheckTask::ProcessFinishedHandler(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr, const Value& commandLine, const ProcessResult& pr)