Github Actions migration #42
Conversation
.github/workflows/atomic_cache.yml
Outdated
| RUBYGEMS_API_TOKEN: "${{ secrets.RUBYGEMS_API_TOKEN }}" | ||
| GITHUB_API_TOKEN: "${{ secrets.GITHUB_API_TOKEN }}" | ||
| encrypted_3b12ef27616a_key: "${{ secrets.ENCRYPTED_3B12EF27616A_KEY }}" | ||
| encrypted_3b12ef27616a_iv: "${{ secrets.ENCRYPTED_3B12EF27616A_IV }}" |
There was a problem hiding this comment.
these wont just work pulled over i don't think
There was a problem hiding this comment.
I dont have access - are these secrets set via the repo settings? @mersman do you have permissions to see/confirm?
.github/workflows/atomic_cache.yml
Outdated
| ruby-version: 2.6 | ||
| - run: gem install bundler | ||
| - run: bundle install --jobs=3 --retry=3 | ||
| - run: openssl aes-256-cbc -K $encrypted_3b12ef27616a_key -iv $encrypted_3b12ef27616a_iv -in ./ci-helpers/atomic_cache_deploy.enc -out atomic_cache_deploy -d |
There was a problem hiding this comment.
i used a base64 encoded secret for the file in another repo, works a lot better.
There was a problem hiding this comment.
Ya I can switch it to something like this https://github.com/Ibotta/ibotta-schemas/blob/a057520e353887bfe8bcbb059c217c465e2a3474/.github/workflows/build.yaml#L128
.github/workflows/build.yml
Outdated
| ruby-version: 2.7 | ||
| - run: | | ||
| bundle install --jobs=3 --retry=3 | ||
| openssl aes-256-cbc -K $encrypted_3b12ef27616a_key -iv $encrypted_3b12ef27616a_iv -in ./ci-helpers/atomic_cache_deploy.enc -out atomic_cache_deploy -d |
There was a problem hiding this comment.
this was created with the travis migrator. does this work?
There was a problem hiding this comment.
Unknown. Im looking at refactoring once I have more info on credentials to use. Im also not a repo admin so I cant add settings, etc to tell which parts we still have available for the release/publish steps.
ec004ba to
ff0e8cb
Compare
commit 13b2a23 Author: Mikhail Slyusarev <mikhail.slyusarev@ibotta.com> Date: Wed May 3 09:26:38 2023 -0700 Revert "🛠️ Auto-fix: Generating team.yml" This reverts commit 66dfe51. commit a6c11b2 Author: Mikhail Slyusarev <mikhail.slyusarev@ibotta.com> Date: Wed May 3 09:26:36 2023 -0700 Revert "🛠️ Auto-fix: Generating main.yml" This reverts commit 96c0c2f. commit 66dfe51 Author: ibotta-catalog[bot] <63963886+ibotta-catalog[bot]@users.noreply.github.com> Date: Wed May 3 16:24:36 2023 +0000 🛠️ Auto-fix: Generating team.yml commit 96c0c2f Author: ibotta-catalog[bot] <63963886+ibotta-catalog[bot]@users.noreply.github.com> Date: Wed May 3 16:24:31 2023 +0000 🛠️ Auto-fix: Generating main.yml commit 603eb5a Author: Mikhail Slyusarev <mikhail.slyusarev@ibotta.com> Date: Wed May 3 09:19:14 2023 -0700 Refactoring Proc.new usage to be blocks explicitly passed to methods.
Background
Travis isnt supported anymore. Also dropping EOL Rails and Ruby versions.
also supports and tests against newer ruby and rails versions.
Closes #44 by merging in here.
Tasks
./lib/atomic_cache/version.rb) when applicable