Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MTF-593] Remove LKV check from Atomic Cache Gem. #38

Merged
merged 1 commit into from
Aug 9, 2021
Merged

[MTF-593] Remove LKV check from Atomic Cache Gem. #38

merged 1 commit into from
Aug 9, 2021

Conversation

AmishNinja
Copy link
Contributor

  • Remove LKV check from wait loop of atomic cache.
  • Increment patch version.
  • Remove LKV test from atomic_cache_client_spec.rb.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@AmishNinja
[MTF-593]
ce7bee1 
* Remove LKV check from wait loop of atomic cache.
* Increment patch version.
* Remove LKV test from atomic_cache_client_spec.rb.
lebeerman
lebeerman reviewed Aug 6, 2021
View reviewed changes
lib/atomic_cache/version.rb
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module AtomicCache
VERSION = "0.5.2.rc1"
VERSION = "0.5.3.rc1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted over this and Im unclear - maybe a 0.6 version is needed? We arent observing the wait.klv.present increment in the dashboard...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked with Titus about this, and he says that a patch version makes the most sense, as while it is not a bug fix per se, it is not a very noticeable change.

lebeerman
lebeerman approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only request would be to add a link/title to the pr for search-ability/archaeology

@AmishNinja AmishNinja changed the title [MTF-593] [MTF-593] Remove LKV check from Atomic Cache Gem. Aug 9, 2021
@AmishNinja
Copy link
Contributor Author

LGTM. Only request would be to add a link/title to the pr for search-ability/archaeology

Good call; added one in. Let me know if the wording should be different!

@AmishNinja AmishNinja merged commit 165b02c into main Aug 9, 2021
@onyxraven onyxraven deleted the task/MTF-593_remove_lkv_checking branch May 5, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebeerman lebeerman lebeerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmishNinja @lebeerman