Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Matrix: Rails 6, 6.1, Ruby 2.7 #37

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Build Matrix: Rails 6, 6.1, Ruby 2.7 #37

merged 5 commits into from
Aug 2, 2021

Conversation

tstone
Copy link
Collaborator

@tstone tstone commented Aug 2, 2021

Background

Updates the Travis build configuration to also build against Rails 6, Rails 6.1, and Ruby 2.7.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@tstone tstone requested a review from a team August 2, 2021 20:46
- Gemfile.rails52
- Gemfile.rails6
- Gemfile.rails61

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, how does the this naming convention work? Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming convention here is just for ease of knowing what's in a file. As far as the Travis config is concerned, these are just three different Gemfiles; it's not interpreting anything special with the .rails52 on the end. If you look down below, you'll see where the actual Rails version is being enforced within the file.

Copy link

@RosanneUssery RosanneUssery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tstone tstone merged commit 8217722 into main Aug 2, 2021
@tstone tstone deleted the MTF-513-rails6-build branch August 2, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants