Clearer metrics Without LKK Delete #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstone
commented
Jul 12, 2021
| # if the value of the last known key is nil, we can infer that it's | ||
| # most likely expired, thus remove it so other processes don't waste | ||
| # time trying to read it | ||
| @storage.delete(lkk) |
There was a problem hiding this comment.
Dropping delete here, as we don't yet know if this is 100% safe. Added a metric in its place.
lebeerman
reviewed
Jul 12, 2021
Comment on lines
+122
to
+124
| metrics(:increment, 'last-known-value.nil', tags: tags) | ||
| else | ||
| metrics(:increment, 'last-known-value.not-present', tags: tags) |
There was a problem hiding this comment.
📏 Measure all teh things!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Tasks
./lib/atomic_cache/version.rb) when applicable