Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR removes the "quick retry" feature of atomic_cache.
Why
Quick retry works best in situations where the cached value changes slowly but the time to re-generate a value is quick. These are unlikely to be situations where the overhead of atomic_cache would be seriously considered. Along these lines, there aren't currently any plans to use quick retry in a production setting at Ibotta, which is yet a further signal that this feature is adding unnecessary complication, and can be removed.
Versioning
This is a backwards-incompatible change to a pre-release gem. To avoid signalling a "production readiness" the version will increment from
0.3.0.rc1
to0.4.0.rc1
.Tasks
./lib/atomic_cache/version.rb
) when applicable