Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quick_retry feature #30

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Remove quick_retry feature #30

merged 2 commits into from
Jul 7, 2021

Conversation

tstone
Copy link
Collaborator

@tstone tstone commented Jul 7, 2021

Background

This PR removes the "quick retry" feature of atomic_cache.

Why

Quick retry works best in situations where the cached value changes slowly but the time to re-generate a value is quick. These are unlikely to be situations where the overhead of atomic_cache would be seriously considered. Along these lines, there aren't currently any plans to use quick retry in a production setting at Ibotta, which is yet a further signal that this feature is adding unnecessary complication, and can be removed.

Versioning

This is a backwards-incompatible change to a pre-release gem. To avoid signalling a "production readiness" the version will increment from 0.3.0.rc1 to 0.4.0.rc1.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@tstone tstone requested review from onyxraven and a team July 7, 2021 17:11
Copy link
Contributor

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there aren't currently any plans to use quick retry in a production setting at Ibotta, which is yet a further signal that this feature is adding unnecessary complication, and can be removed.

Totally agree. Seems like last_known_value check is sufficient.

@tstone tstone merged commit d8b9ad6 into main Jul 7, 2021
@tstone tstone deleted the remove-quick-retry branch July 7, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants