Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version(s) #23

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Fix version(s) #23

merged 1 commit into from
Jun 24, 2021

Conversation

tstone
Copy link
Collaborator

@tstone tstone commented Jun 24, 2021

Background

Add background information that will be helpful to reviewers:

  • Why are we making this change?
  • How you arrived at this solution
  • High level overview of when / how this code is executed

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

lebeerman
lebeerman approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@lebeerman lebeerman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. 🔥

@tstone tstone merged commit c55da7d into main Jun 24, 2021
@tstone tstone deleted the fix-version branch June 24, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebeerman lebeerman lebeerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstone @lebeerman