Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Dalli Client response codes #20

Merged
merged 3 commits into from
Jun 23, 2021
Merged

BUG: Dalli Client response codes #20

merged 3 commits into from
Jun 23, 2021

Conversation

tstone
Copy link
Collaborator

@tstone tstone commented Jun 23, 2021 •
edited
Loading

Background

Previous Dalli client was expecting a string response. Updated to expect truthy or falsey values.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@tstone tstone marked this pull request as ready for review June 23, 2021 22:11
lebeerman
lebeerman approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tstone tstone merged commit c5fc5a3 into main Jun 23, 2021
@tstone tstone deleted the dalli-client-fix2 branch June 23, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebeerman lebeerman lebeerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstone @lebeerman