Bug: Properly interface with Dalli client #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebeerman
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
This makes sense to me. Only additional though around if atomic_cache should expect a default ttl when using a Dalli client when the :expires_in option is used on init. Guess this is more specific than the gem needs to be? (e: per DM - 👍 Dalli owns the default value behavior)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Dalli storage adapter appears to incorrectly assume the adapter is
Rails.cacheinstead of the actual Dalli client. This PR changes it to expect the Dalli client.Tasks
./lib/atomic_cache/version.rb) when applicable