Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor maintenance #18

Merged
merged 2 commits into from
Jun 22, 2021
Merged

minor maintenance #18

merged 2 commits into from
Jun 22, 2021

Conversation

tstone
Copy link
Collaborator

@tstone tstone commented Jun 22, 2021

Background

This PR handles a couple minor maintenance tasks:

  • Sets default Ruby version to 2.6
  • Adds RubyMine/IntelliJ project files to git ignore
  • Adds a test to confirm that running configure multiple times is successful (a question about this came up)

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

lebeerman
lebeerman reviewed Jun 22, 2021
View reviewed changes
.ruby-version
@@ -1 +1 @@
2.5.8
2.6.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

lebeerman
lebeerman approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, configuring the thing will change the thing.

@tstone tstone merged commit a3fcf7b into main Jun 22, 2021
@tstone tstone deleted the minor-maintenance branch June 22, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebeerman lebeerman lebeerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstone @lebeerman