Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruby versions #16

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Bump ruby versions #16

merged 2 commits into from
Apr 24, 2018

Conversation

onyxraven
Copy link
Member

@onyxraven onyxraven commented Apr 17, 2018

Bump ruby versions to the latest

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@onyxraven onyxraven changed the title Background ----- Bump ruby versions Apr 17, 2018
.travis.yml Outdated
script:
- bundle exec rake spec

- stage: test-2.5
rvm: 2.5.0
rvm: 2.5.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternately, we could leave the patch version and always get the latest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me (to always test patch versions)

@onyxraven onyxraven merged commit 72994b5 into master Apr 24, 2018
@onyxraven onyxraven deleted the bump_ruby_version branch April 24, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants