Feature/pr template #15
Conversation
| * [ ] Specs written and passing | ||
| * [ ] Backwards-incompatible changes called out in this PR | ||
| * [ ] Increment the version file (`./lib/atomic_cache/version.rb`) when applicable | ||
| * See [semver.org](https://semver.org/) for what segment to increment |
There was a problem hiding this comment.
Are lines 14 and 15 enough? I'm a little concerned about the "when applicable" phrasing as it might not be obvious to everyone when/if this should happen.
There was a problem hiding this comment.
https://github.com/Ibotta/sopstool/blob/master/.github/PULL_REQUEST_TEMPLATE.md is slightly different - it has a separate versioning section
There was a problem hiding this comment.
Personally, I'm OK with this. I think that if someone's not sure they'll ask.
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| @mention any specific individuals you'd like to be aware of this change: | ||
| * Who is impacted by the work? | ||
| * Who knows this code best and can provide useful feedback? |
There was a problem hiding this comment.
I know that this section is really valuable for our internal PR template, but does this provide value to external contributors? I worry that many might feel left-out before of this, thinking "I don't know, but I want to contribute!".
Maybe we omit the whole cc section?
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| @mention any specific individuals you'd like to be aware of this change: | ||
| * Who is impacted by the work? | ||
| * Who knows this code best and can provide useful feedback? |
There was a problem hiding this comment.
Related, should we add a CODEOWNERS file in this repo?
There was a problem hiding this comment.
I opened a poll on this in the #ibotta_open_source slack channel.
| * [ ] Specs written and passing | ||
| * [ ] Backwards-incompatible changes called out in this PR | ||
| * [ ] Increment the version file (`./lib/atomic_cache/version.rb`) when applicable | ||
| * See [semver.org](https://semver.org/) for what segment to increment |
There was a problem hiding this comment.
Personally, I'm OK with this. I think that if someone's not sure they'll ask.
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| @mention any specific individuals you'd like to be aware of this change: | ||
| * Who is impacted by the work? | ||
| * Who knows this code best and can provide useful feedback? |
In talking with @lucas-ibotta about this repo, it seems like it would be helpful to call out a few of the necessary tasks when submitting a PR. This PR takes a first pass at a gem-specific PR template.