-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagonal
as a generalization of LinearAlgebra.Diagonal
#4
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 77.20% 77.37% +0.16%
==========================================
Files 11 11
Lines 136 137 +1
==========================================
+ Hits 105 106 +1
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks good, thanks. Can you add a test? Also, I guess we should start listing docstrings in the docs... |
I tried something out to make a |
diagonal
diagonal
as a generalization of LinearAlgebra.Diagonal
This adds a utility entrance-point to turn a vector into a diagonal matrix, without implying the return type. Specifically, it adds
diagonal
, which relates toDiagonal
in the same way thatadjoint
relates toAdjoint
.The main purpose is to have the ability to write generic code, without having to force everything to be of type
Diagonal
.