-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3818 Delete temporary thumbnail files #9637
3818 Delete temporary thumbnail files #9637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but the code makes sense.
I'm hitting "approve" but this still need to be prioritized.
@haarli I added it near the top of the community column of the backlog. I hope it helps! Thanks for the pull request!
@haarli, we'd like to merge this PR. Can you please update this branch with the latest from develop and see if the Jenkins build succeeds? Thanks! |
@sekmiller Sure, the branch is now updated |
What this PR does / why we need it:
With S3 storage activated, Dataverse creates temporary thumbnail files (tempFileForRescale*.tmp) for image and PDF ingests. After the thumbnails are uploaded to S3, the temporary files are not deleted. Our tmp directory currently grew up to over 180GB .
This PR deletes the tempFileForRescale*.tmp files silently after they are uploaded to S3.
Which issue(s) this PR closes: