Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <dataverse_home>/scripts/installer/default.config as the template used in documentation #8618

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

j-n-c
Copy link
Contributor

@j-n-c j-n-c commented Apr 19, 2022

Added <dataverse_home>/scripts/installer/default.config as the template used in documentation

What this PR does / why we need it:

default.config sample file available for download in the installation guide is out of date and uses a differente format from the one available in dvinstall.zip (from the releases page)

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
Download the default.config sample file from the iinstallation guide,
Open the file and check that its contents are the same as <dataverse_home>/scripts/installer/default.config

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make html but the change makes sense except that we should git rm the old, obsolete config file.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't build the docs and check the link but the syntax looks right and the tests pass.

@kcondon kcondon self-assigned this Apr 22, 2022
@kcondon kcondon merged commit d730004 into IQSS:develop Apr 22, 2022
@pdurbin pdurbin added this to the 5.11 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants