7991 fontcustom #8021
Merged
7991 fontcustom #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to be able to update custom icons in the app (and the guides).
Which issue(s) this PR closes:
Closes #7991
Special notes for your reviewer:
You are encouraged to try to get fontcustom running. It works on my machine but will it work on yours?
Suggestions on how to test this:
Build the war file and the docs. Make sure the icons look ok in both.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. The dataset icon should look different. The document icon was also tweaked slightly. The code icon was updated as well but only very slightly. The rest of the icons were build from SVGs extracted from a .ttf file so the inputs are different but the look should be the same.
Here's a screenshot from the icon preview page, a new addition to the guides:
Is there a release notes update needed for this change?:
Probably not.
Additional documentation:
Docs are included.