6672-Fix Workflow Resume #7521
Merged
6672-Fix Workflow Resume #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This fixes a bug introduced in 2018 :-) that resulted in different workflow Ids being recorded in the db and log (and presumably sent the an external client with the https/r workflow step), making it 'hard' to resume the workflow and, for prepublish workflows to then finalize publication. (Things worked if you could get the correct invocationid from the database).
Which issue(s) this PR closes:
Closes #6672
Special notes for your reviewer:
Suggestions on how to test this: Set up and running a workflow including the pause step. You should then be able to post a success/fail message and have it work. All per Guides instruction. Note that one can test the combo of this and #7519 by setting this up a pre-publication workflow. This fix will allow you to unpause the workflow and #7519 will assure that publication is not finalized until after you do.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?:
Additional documentation: