-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7398 saved search performance #7510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposed reorganization of query docs and release notes for 7398
7398 saved search script reorg
sekmiller
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Vastly improves performance for saved search.
Which issue(s) this PR closes:
Closes #7398
Special notes for your reviewer:
The majority of the improvements will be when rerunning a search and parsing through already linked objects. e.g some saved searches, even though they were not adding anything new would take hours; these should now take seconds, maybe minutes.
There is still more work that can be done to improve things here, but feels lower priority at this point.
Suggestions on how to test this:
Try running some saved searches to a) confirm they still work as expected and b) that times are vastly reduced (while the initial link creation should be improved, note that the major improvements will be when rerunning a search and parsing through already linked objects).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
yes, some suggested db cleanup
Additional documentation: