Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7398 saved search performance #7510

Merged
merged 14 commits into from
Jan 27, 2021
Merged

7398 saved search performance #7510

merged 14 commits into from
Jan 27, 2021

Conversation

scolapasta
Copy link
Contributor

@scolapasta scolapasta commented Jan 15, 2021

What this PR does / why we need it:
Vastly improves performance for saved search.

Which issue(s) this PR closes:

Closes #7398

Special notes for your reviewer:
The majority of the improvements will be when rerunning a search and parsing through already linked objects. e.g some saved searches, even though they were not adding anything new would take hours; these should now take seconds, maybe minutes.

There is still more work that can be done to improve things here, but feels lower priority at this point.

Suggestions on how to test this:
Try running some saved searches to a) confirm they still work as expected and b) that times are vastly reduced (while the initial link creation should be improved, note that the major improvements will be when rerunning a search and parsing through already linked objects).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no

Is there a release notes update needed for this change?:
yes, some suggested db cleanup

Additional documentation:

@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage increased (+0.007%) to 19.621% when pulling 89821ab on 7398-saved-search-performance into 56b5b27 on develop.

@sekmiller sekmiller self-assigned this Jan 21, 2021
@sekmiller sekmiller removed their assignment Jan 25, 2021
@kcondon kcondon self-assigned this Jan 25, 2021
@kcondon kcondon merged commit 8ae661d into develop Jan 27, 2021
@kcondon kcondon deleted the 7398-saved-search-performance branch January 27, 2021 17:02
@djbrooke djbrooke added this to the 5.4 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved Search not Populating records as expected in dataverse.harvard.edu
5 participants