-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6230 gf upgrade part deux #6796
Conversation
editMode is set in the init method and is not used as a viewParam
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. Couldn't tell what, if anything, changed on this line. Same with the template.xhtml file.
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as on guestbook.xhtml. What changed?
I'm seeing this in logs when I add multiple options Also am seeing this is logs when guestbook with multiple choice questions appear, one for each question. Otherwise it functions. [2020-04-07T17:55:44.128-0400] [glassfish 4.1] [WARNING] [jsf.externalcontext.no.mime.type.found] [javax.enterprise.resource.webcontainer.jsf.context] [tid: _ThreadID=149 _ThreadName=jk-connector(3)] [timeMillis: 1586296544128] [levelValue: 900] [[ [2020-04-07T17:55:44.130-0400] [glassfish 4.1] [WARNING] [jsf.externalcontext.no.mime.type.found] [javax.enterprise.resource.webcontainer.jsf.context] [tid: _ThreadID=149 _ThreadName=jk-connector(3)] [timeMillis: 1586296544130] [levelValue: 900] [[ |
The same thing occurs with dev branch, that is this is not introduced by this change. Since this PR isn't the cause and this allows us to get past some issues on payara5, I'd like to still merge this now. |
What this PR does / why we need it:
Fixes issues on template and guestbook pages dealing with editMode
Which issue(s) this PR closes:
Closes #6230
(though we may not want to close #6230 until #6595 testing is complete)
Special notes for your reviewer:
editMode viewparam changed to omnifaces for templates
editMode viewparam removed completely from guestbooks, as it was not used
Suggestions on how to test this:
Make sure you can add authors on templates; multiple choice questions / options on guestbook
Does this PR introduce a user interface change?:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
this code change was made to work with Payara5, but is backwards compatible with Glassfish 4.1