Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5867 api for hash verification regeneration #6228

Merged
merged 9 commits into from
Oct 2, 2019

Conversation

sekmiller
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

  • Unit [tests][x] NA
  • Integration [tests][x]: completed
  • Deployment requirements: [x] None
  • Documentation [x] completed
  • Merged latest from "develop" [branch][x] and resolved conflicts

@dataversebot
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Sep 30, 2019

Coverage Status

Coverage decreased (-0.02%) to 19.467% when pulling 5ca65ca on 5867-api-for-hash-verification-regeneration into 731f160 on develop.


Recalculate the check sum value value of a datafile, by supplying the file's database id and an algorithm::

POST http://$SERVER/api/admin/computeDataFileHashValue/{fileId}/algorithm/{alg}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a full curl command and can the {alg} options be enumerated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated per suggestion. thanks!

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of 5ca65ca the docs look much better! I'm clicking "Comment" instead of "Approve" because I'm not actually looking at the code. @landreev is. Thanks, @sekmiller !

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@landreev landreev removed their assignment Sep 30, 2019
@kcondon kcondon merged commit d1d1f89 into develop Oct 2, 2019
@kcondon kcondon deleted the 5867-api-for-hash-verification-regeneration branch October 2, 2019 16:21
@kcondon kcondon self-assigned this Oct 2, 2019
@djbrooke djbrooke added this to the 4.17 milestone Oct 2, 2019
@djbrooke
Copy link
Contributor

djbrooke commented Oct 2, 2019

Hey @donsizemore - this will go out in the next release. If you'd like, feel free to test it and provide feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants