5456 external tools for other mimetypes #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
requested changes
Jan 25, 2019
| @@ -0,0 +1 @@ | |||
| ALTER TABLE externaltool ADD COLUMN contenttype text; | |||
There was a problem hiding this comment.
Two things:
Should this have a NOT NULL in it to be consistent with @Column(nullable = false)?
Are we sure the next version is 4.10.2? This may be a question for @djbrooke .
5456-External_tools_for_other_mimetypes Conflicts: src/test/java/edu/harvard/iq/dataverse/externaltools/ExternalToolHandlerTest.java
and the fact that external tools can work on other mimetypes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist