Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4579 solr 7.3.0 #4621

Merged
merged 4 commits into from
Apr 30, 2018
Merged

4579 solr 7.3.0 #4621

merged 4 commits into from
Apr 30, 2018

Conversation

matthew-a-dunlap
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap commented Apr 25, 2018

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 13.369% when pulling 4f0d7e4 on 4579-solr-7.3.0 into 0e38c90 on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what conf/docker-aio/testdata/httpd.conf is for but I'm happy with the output of ack -Q 7.2.1. Approved.

# glassfish can be slow sometimes
ProxyTimeout 300

</VirtualHost>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a file that was missing from the docker-aio folder. .gitignore has blocked it when the configuration was last committed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Ok. Thanks for explaining this.

@kcondon kcondon merged commit 81bd2a4 into develop Apr 30, 2018
@kcondon kcondon deleted the 4579-solr-7.3.0 branch April 30, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants