4158 update solr #4520
Merged
4158 update solr #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like 7.1 is not much more work, but this is the lowest bar to start with.
I am unsure if this is actually the correct approach but am committing it as this story is getting backlogged.
Dev work still needed
Discusses how to set up 7.2.1. There are still guide fixes needed around various scripts and configuration of jetty in solr
Solr 4.6.0 folder still exists at this point as I need to understand all the files inside.
Removed 4.6.0 folder updated a script (more to come) updated documentation
These still need testing
Hopefully got them all. Still untested
Also remove comment from a solr script
Plus other minor cleanup.
pdurbin
approved these changes
Mar 21, 2018
This is an awful hack to just get Solr working at all. We were getting AccessDeniedException when starting it. FIXME added. The Dockerfile was also simplified to remove lines that don't seem to serve any apparent purpose: RUN ln -s /usr/local/solr-7.2.1/server/logs /var/log/solr VOLUME /usr/local/solr-7.2.1/server/solr/collection1/data
Also add more error checking to build.sh Also track default.config used in minishift/openshift.
"Match" was showing up because the bundle key didn't exist. We are switching away from the deprecated "JsfHelper.localize" method.
Back in 60e640b when I was playing with spelling suggestions from Solr I changed the request handler from "/select" (the default) to "/spell". We didn't have time to fully explore the spelling suggestions feature of Solr during the 4.0 rewrite and the "/spell" request handler seems to be leading to other bugs, such as not being able to search on the "identifier" portion of a DOI (i.e. "JNIUOA") from basic search. In short we are switching to the default request handler for Solr, something I would have done before tagging 4.0 if I had realized I had left the "/spell" request handler in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Pull Request Checklist