Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UNF recalculation endpoint #3589 #3605

Merged
merged 10 commits into from
Feb 8, 2017
Merged

add UNF recalculation endpoint #3589 #3605

merged 10 commits into from
Feb 8, 2017

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 27, 2017

RFI Checklist

1. Related Issues


2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 9.569% when pulling 1bba295 on 3589-unf-recalc into 97bf17b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.642% when pulling a8fbc08 on 3589-unf-recalc into 97bf17b on develop.

changed the name of the API method, to be more REST-like;
modified the "fix" method to only recalculate the unf for versions that don't have one.
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed;
Also made the change per the discussion with Gustavo (limit the fixUnf method to only be able to recalculate the unf for a version that misses one);
also changed the names of some methods, to be more REST-like and/or to be more informative/accurate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.641% when pulling 41fa5fa on 3589-unf-recalc into 97bf17b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.641% when pulling 7464d7c on 3589-unf-recalc into 1ba73ed on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.641% when pulling 08d50a4 on 3589-unf-recalc into 1ba73ed on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.641% when pulling 50be9f3 on 3589-unf-recalc into 1ba73ed on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.641% when pulling 50be9f3 on 3589-unf-recalc into 1ba73ed on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 9.652% when pulling cc4158c on 3589-unf-recalc into 1ba73ed on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 9.73% when pulling 019bbb3 on 3589-unf-recalc into 50019da on develop.

@kcondon kcondon merged commit cfc1c78 into develop Feb 8, 2017
@kcondon kcondon deleted the 3589-unf-recalc branch February 8, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants