Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Maven cache management for Github Actions #10492

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Apr 15, 2024

What this PR does / why we need it:

  • Create a common cache to draw from when no branch caches exists
  • Rejuvenate the common cache to ensure it's around using pushes, schedule or manual runs
  • To save space, we automatically trigger a job on a closed PR to delete any caches for the feature branch just merged

This PR is necessary to be merged before we resolve the issue #10428, as we cannot test the functionality without the cache from the default branch being present. This is due to the scoped nature of caches on Github to ensure cache isolation. We cannot create a cache with the default branch scope from a feature branch.

Which issue(s) this PR closes:

Relates to #10428, but does not close it yet.

Special notes for your reviewer:

None

Suggestions on how to test this:

None (another PR forthcoming to actually test if this works)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Nope

Is there a release notes update needed for this change?:

Nope

Additional documentation:

None

- Create a common cache to draw from when no branch caches exist
- Rejuvenate the common cache to ensure it's around using pushes,
  schedule or manual runs
- To save space, we automatically trigger a job on a closed PR to delete
  any caches for the feature branch just merged
@poikilotherm poikilotherm added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Apr 15, 2024
@poikilotherm poikilotherm self-assigned this Apr 15, 2024
@poikilotherm poikilotherm changed the title Enable Maven cache management Enable Maven cache management for Github Action Apr 15, 2024
@poikilotherm poikilotherm changed the title Enable Maven cache management for Github Action Enable Maven cache management for Github Actions Apr 15, 2024
@poikilotherm poikilotherm added the Size: 0.5 A percentage of a sprint. 0.35 hours label Apr 15, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos

"Deplete" seems harder to understand than just plain ol' "delete".

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge.

@pdurbin pdurbin merged commit b42d469 into develop Apr 16, 2024
1 of 2 checks passed
@pdurbin pdurbin deleted the 10428-maven-cache branch April 16, 2024 14:32
@pdurbin pdurbin added this to the 6.3 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants