Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PUBLICATION_STATUS facet order and visibility #10408

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Mar 21, 2024

What this PR does / why we need it:

It was reported that the order of the facets was unintentionally changed, this PR adds the publication status facet back to the original place, it also was discussed on Slack that users can see objects even if they are not published if the owner grants access to the group.

Which issue(s) this PR closes:

Closes #10338

Suggestions on how to test this:

  • If you are logged in and you have objects with published, draft and/or unpublished status you should see this facet on the top of the left side.
  • If you create a dataset unpublished and give access to everyone you should be able to see this facet on the top while not being logged in.
  • If you have a dataset on draft and give access to everyone you should be able to see this facet on the top while not being logged in.

Is there a release notes update needed for this change?:
Yes

This comment has been minimized.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should resolve the issue

This comment has been minimized.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:expose-and-sort-publish-status-facet
ghcr.io/gdcc/configbaker:expose-and-sort-publish-status-facet

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@jp-tosca jp-tosca added the Size: 3 A percentage of a sprint. 2.1 hours. label Mar 22, 2024
@pdurbin
Copy link
Member

pdurbin commented Mar 22, 2024

Looks good to me:

Screenshot 2024-03-22 at 2 36 03 PM

Screenshot 2024-03-22 at 2 36 19 PM

Screenshot 2024-03-22 at 2 36 41 PM

@pdurbin pdurbin self-assigned this Mar 22, 2024
@pdurbin pdurbin merged commit 30666f9 into develop Mar 22, 2024
18 of 19 checks passed
@pdurbin pdurbin deleted the expose-and-sort-publish-status-facet branch March 22, 2024 18:38
@pdurbin pdurbin removed their assignment Mar 22, 2024
@pdurbin pdurbin added this to the 6.2 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move publication status facet from bottom to where it used to be
3 participants