Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump solrj per qqmyers to address zookeeper dependency #10283

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

donsizemore
Copy link
Contributor

What this PR does / why we need it:

Bumps solr-solrj version to address dataverse-security #95

Which issue(s) this PR closes:

Closes dataverse-security #95

Special notes for your reviewer:

per @qqmyers According to Apache, solrj is usually cross-compatible with solr, so it sounds like solrj 9.4.1 would work with solr 9.3. So it looks like we could update solrj w/o requiring an update to solr itself. (From QDR, I know that solr 9.4.0 works with solrj 9.3 - the other direction.)

Suggestions on how to test this:

standard integration tests?

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

no

Additional documentation:

none

@donsizemore donsizemore requested a review from qqmyers January 30, 2024 15:17
@coveralls
Copy link

Coverage Status

coverage: 20.143%. remained the same
when pulling 3b2a9eb on 95_bump_solrj
into f16c4a1 on develop.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:95-bump-solrj
ghcr.io/gdcc/configbaker:95-bump-solrj

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Feb 20, 2024
@jp-tosca jp-tosca self-assigned this Apr 15, 2024
@jp-tosca jp-tosca merged commit 3def448 into develop Apr 15, 2024
18 checks passed
@jp-tosca jp-tosca removed their assignment Apr 15, 2024
@pdurbin pdurbin added this to the 6.3 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants