Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty dropdown under "Account Information" button for Shib users #8223

Closed
pdurbin opened this issue Nov 8, 2021 · 4 comments · Fixed by #8579
Closed

Empty dropdown under "Account Information" button for Shib users #8223

pdurbin opened this issue Nov 8, 2021 · 4 comments · Fixed by #8579
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 8, 2021

What steps does it take to reproduce the issue?

  • Log into https://demo.dataverse.org with Institutional Login (Shibboleth)
  • Go to Account page.
  • Click "Account Information" button
  • Observe empty dropdown (screenshot below)

To whom does it occur (all users, curators, superusers)?

All users.

What did you expect to happen?

I'm pretty sure that previously the "Account Information" button shouldn't appear at all?

Which version of Dataverse are you using?

Dataverse 5.8 but I'm seeing the same on Dataverse 5.6.

Screenshots:

Screen Shot 2021-11-08 at 12 00 56 PM

Thanks to @PaulBoon for noticing this!

@PaulBoon
Copy link
Contributor

PaulBoon commented Nov 9, 2021

Thanks for creating this issue @pdurbin. This problem was discovered by Tim Warbout, a user of DataverseNL, so all credits for finding it go to him.

@donsizemore
Copy link
Contributor

@pdurbin Just a note that I've reproduced this on 5.3:
Screen Shot 2021-11-24 at 11 08 23

The Payara log is quiet as I'd expect; Firefox's browser console not so much:

Attempt to override an existing term: "brand-shorter-name". branding/brand.ftl
Attempt to override an existing term: "brand-short-name". branding/brand.ftl
Attempt to override an existing term: "brand-full-name". branding/brand.ftl
Attempt to override an existing term: "brand-product-name". branding/brand.ftl
Attempt to override an existing term: "vendor-short-name". branding/brand.ftl
Attempt to override an existing message: "trademarkInfo". branding/brand.ftl
[Exception... "Favicon at "https://sso.unc.edu/favicon.ico" failed to load: Forbidden."  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 253"  data: no] FaviconLoader.jsm:253:22
Content Security Policy: Ignoring “'unsafe-inline'” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “https:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “'unsafe-inline'” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “https:” within script-src: ‘strict-dynamic’ specified
Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified

@pdurbin pdurbin self-assigned this Apr 8, 2022
@pdurbin
Copy link
Member Author

pdurbin commented Apr 8, 2022

Before making any changes, as of 5.10.1, here what a builtin user and a shib user see:

Builtin user (dropdown to edit account or password)

Screen Shot 2022-04-08 at 2 33 35 PM

Shib user (weird broken dropdown)

Screen Shot 2022-04-08 at 2 35 38 PM

@pdurbin
Copy link
Member Author

pdurbin commented Apr 8, 2022

In this pull request, I removed the weird empty "Account Information" popup:

@pdurbin pdurbin added this to the 5.11 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants