Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File tags to advanced search, update dataset page to allow file tag searching (with proper syntax) #7194

Closed
scolapasta opened this issue Aug 12, 2020 · 8 comments

Comments

@scolapasta
Copy link
Contributor

Currently you can type fileTags:XXXXX and dataverse will search the index for XXXXX in the fileTags. But we should add this as a field in Advanced Search, so the user does not need to know this syntax.

(additionally we need to make sure it works this way from the dataset page, as in some quick tests fileTags:XXXXX did not return results as expected)

@scolapasta
Copy link
Contributor Author

An example of the fileTags search prefix working:

image

@scolapasta
Copy link
Contributor Author

scolapasta commented Aug 12, 2020

But not on the dataset Page:

image

@TaniaSchlatter
Copy link
Member

TaniaSchlatter commented Aug 17, 2020

Expected outcomes:

  • users can type the term on a tag into a new field on the advanced search page
  • users can search on the dataset page for a file tag term using the "fileTags:" syntax.

@djbrooke djbrooke added the Small label Aug 18, 2020
@djbrooke djbrooke changed the title Add File tags to advanced search Add File tags to advanced search, update dataset page to allow file tag searching (with proper syntax) Oct 27, 2020
@pdurbin pdurbin self-assigned this Nov 3, 2020
@pdurbin
Copy link
Member

pdurbin commented Nov 3, 2020

I just poked around the code and will go ahead and make a pull request to add "File Tags" to the Advanced Search page. Making this change is easy and straightforward (in line with the "Small" estimate) and clearly provides value, surfacing a feature in the UI that was hidden. Here's how it looks (feedback welcome):

Screen Shot 2020-11-03 at 3 10 41 PM

The other thing that's being suggested in this issue is to allow users to type "fileTags:GOAT" (for example) into the search at the dataset level. Very few users will want to do this (or remember to prepend "fileTags:" to their query) and rather than a significant rewrite of the code to support this, I'd like to suggest a couple alternatives.

Alternative 1 is to simply point users to the nice existing feature where they can click "File Tag" and then click on the tag they are interested in. Here's an example from https://doi.org/10.7910/DVN/NSTBR7 :

Screen Shot 2020-11-03 at 3 28 15 PM

Alternative 2 is to make file tags searchable without requiring "fileTags:GOAT" (for example). You would just type "GOAT". Right now filename and description is searched and the fix would be to add file tags to the list of fields that are searched. Here's an example of searching for the tag "Foo Bar":

Screen Shot 2020-11-03 at 3 47 18 PM

@djbrooke
Copy link
Contributor

djbrooke commented Nov 3, 2020

Thanks @pdurbin for starting the discussion and bringing up the alternatives. I was under the impression that the filetags:xxx on the dataset search was a small change but it sounds like it may be bigger. I use the functionality on Github (for label: anyway) and I could see it being useful here when there are lots of files or tags, but if it's not easy then it's definitely worth discussing cost/benefit.

Another alternative is how Google handles this - if the inputted text matches a label, it suggests it as an option:

Screen Shot 2020-11-03 at 4 03 31 PM

It'll be good to get a take from @TaniaSchlatter here as well.

@qqmyers
Copy link
Member

qqmyers commented Nov 3, 2020

FWIW: Aside from being rather hidden, the fileTags:GOAT in the simple search box option, and the fact that the simple search accepts the full solr query grammar, makes it very hard to implement full text search on restricted files. (See QDR's implementation and enjoy the regexps - they're the reason there was no PR for this. The basic issue is that if there are indexed things with different levels of restriction (open metadata and restricted file contents today, but DataTags going forward), then the search logic has to deal with all the and/or/not logic, special fields tags, etc. that go in the simple search field.)

My vote would be to keep simple search simple (and make it simpler than it is now) and support other features via the advanced search and/or other means.

@pdurbin pdurbin removed their assignment Nov 3, 2020
kcondon added a commit that referenced this issue Nov 12, 2020
file tags searchable from advanced search and dataset page #7194
@TaniaSchlatter
Copy link
Member

Alternative 2 that @pdurbin describes would be great: make file tags searchable without requiring "fileTags:GOAT" (for example). You would just type "GOAT".

@mreekie mreekie removed the sz.Small label Jan 11, 2023
@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants