Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer I don't want outages of http://maven.geotoolkit.org to prevent me from compiling a war file #5312

Closed
pdurbin opened this issue Nov 14, 2018 · 7 comments
Assignees

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 14, 2018

As noted in a variety of places...

... our dependency on http://maven.geotoolkit.org being up causes considerable frustration when jar files aren't already cached in ~/.m2 such as when we spin up arbitrary branches on AWS, run Travis builds, set up new developers, etc.

This dependency was added in 64aa054 and is still used in generateImageThumbnailFromInputStream for example: https://github.com/IQSS/dataverse/blob/v4.9.4/src/main/java/edu/harvard/iq/dataverse/dataaccess/ImageThumbConverter.java#L330

Here's how the failure looks at https://travis-ci.org/IQSS/dataverse/builds/455025056 for example:

screen shot 2018-11-14 at 12 18 08 pm

[ERROR] Failed to execute goal on project dataverse: Could not resolve dependencies for project edu.harvard.iq:dataverse:war:4.9.4: Failed to collect dependencies at javax.media:jai_imageio:jar:1.1.1: Failed to read artifact descriptor for javax.media:jai_imageio:jar:1.1.1: Could not transfer artifact javax.media:jai_imageio:pom:1.1.1 from/to geotk-repo (http://maven.geotoolkit.org): Failed to transfer file: http://maven.geotoolkit.org/javax/media/jai_imageio/1.1.1/jai_imageio-1.1.1.pom. Return code is: 502 , ReasonPhrase:Bad Gateway. -> [Help 1]

@matthew-a-dunlap
Copy link
Contributor

There are two options to fix this immediately. We can either store this in our local_lib or find a new repo to point towards. The downside with local_lib is it'll increase our app size by ~3mb. I'm looking into a different repo currently.

@matthew-a-dunlap
Copy link
Contributor

Regardless of which option we take, we should probably look for a different library to rely on for the small amount of use we have for these jai_ libraries. Maybe something already imported.

@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Nov 14, 2018

Ignore my previous comment, this library is still being maintained as a github project, has been updated and is in maven central. I've updated our build to use the latest version and have tested it on thumbnails.

During this research I learned that the repository order in pom.xml alters which one maven looks to first. I've updated our to look to the maven central repo first (instead of primeface's which has almost nothing), hopefully this will speed up fresh builds / travis / aws-autodeploy .

@poikilotherm
Copy link
Contributor

poikilotherm commented Nov 15, 2018

Sorry to necro this, but I did not want to open a new issue...

@matthew-a-dunlap: about the repo ordering - maybe a hint about this might be usefull in the new docs about dependency management I want to merge in #5289?

@pdurbin
Copy link
Member Author

pdurbin commented Nov 15, 2018

@poikilotherm good idea. Please go ahead and add a line about the repo ordering in your new "developers/dependencies.rst" doc if you feel like it!

poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 15, 2018
@poikilotherm
Copy link
Contributor

@pdurbin: Sir, done, Sir! 😉

@pdurbin
Copy link
Member Author

pdurbin commented Nov 15, 2018

@poikilotherm thanks! I see it in f2274bf.

poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 21, 2018
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 21, 2018
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 21, 2018
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants