Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PrimeFaces 5 #2730

Closed
pdurbin opened this issue Nov 6, 2015 · 5 comments
Closed

Upgrade to PrimeFaces 5 #2730

pdurbin opened this issue Nov 6, 2015 · 5 comments
Assignees
@kcondon
Labels
Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
4.2.3

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 6, 2015

Dataverse 4 is using PrimeFaces 4.0 but we are planning to upgrade: https://github.com/primefaces/primefaces/wiki/Migration-Guide
@pdurbin pdurbin added Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev labels Nov 6, 2015
@pdurbin pdurbin added this to the 4.3 milestone Nov 6, 2015
@sekmiller sekmiller mentioned this issue Nov 6, 2015
Closed
2 tasks
sekmiller added a commit that referenced this issue Nov 9, 2015
@sekmiller
Preliminary commit for #2731, #2730, #2151
8768e05 
To get Mike unstuck.  Glassfish will be done soon
mheppler added a commit that referenced this issue Nov 9, 2015
@mheppler
Cleaned up minor layout issue with the col widths of the files table …
c821226 
…on the dataset pg. [ref #2731 #2730]
@mheppler
Copy link
Contributor

mheppler commented Nov 9, 2015

Cleaned up minor layout issue with the col widths of the files table on the dataset pg.

In the PrimeFaces 5.1 release notes, there is a reference to "improved scrollable datatable implementation". I believe it was those improvements/changes, that caused the CSS/UI issues I found.

Here are links to other release announcements for PrimeFaces 5.0, PrimeFaces 5.2, and PrimeFaces 5.3.

@mheppler mheppler changed the title Upgrade from Primefaces 4 Upgrade to Primefaces 5 Nov 10, 2015
@mheppler
Copy link
Contributor

Outline of code changes required for upgrading to 5.3.

  • Move disabledSelection logic from column to table -- 8768e05
    • permissions-manage-files.xhtml - assignedRoles
  • Change LazyDataModel filter parameter to Map<String,Object> -- 8768e05
    • LazyFileMetadataDataModel.java
  • Change widgetVar reference format in buttons for popups -- 8768e05
    • contactFormFragment.xhtml
    • dataset.xhtml - shareDialog/deleteConfirmation/deleteVersionConfirmation/deleteFileConfirmation/deleteSelectedFileConfirmation/deaccessionBlock/deaccessionConfirmation/deaccessionAllConfirmation/compareTwo/detailsBlocks/selectFilesForDownload/selectFilesForRequestAccess/selectFilesForDelete/selectFilesForEditMetadata/fileTagsPopup/accessSignUpLogIn/downloadPopup/linkDatasetForm/accessPopup/inreview/publishConfirm/publishParent/releaseDraft/mayNotRelease/maynotPublishParent/sendBackToContributor
    • dataverse.xhtml - contactForm
    • dataverse_header.xhtml - statusInfo/contactForm
    • dataverse_template.xhtml - statusInfo
    • editFilesFragment.xhtml - editFileTagsPopup/fileSetThumbnail/fileAdvancedOptions/deleteFileConfirmation/editFileAccessPopup/fileAdvancedOptions/fileSetThumbnail/editFileTagsPopup
    • editdatafiles.xhtml - blockFileForm
    • explicitGroup-new-dialog.xhtml
    • file.xhtml - deleteFileConfirmation/contactForm/shareDialog/deleteFileConfirmation
    • manage-groups.xhtml - explicitGroupForm/viewGroup/deleteConfirmation
    • manage-guestbooks.xhtml - viewGuestbook/deleteConfirmation
    • manage-templates.xhtml - viewTemplate/deleteConfirmation
    • permissions-manage-files.xhtml - assignWidget/viewRemoveWidget/confirmation
    • permissions-manage.xhtml - accessForm/userGroupsForm/confirmation/roleForm
  • Fix CSS for scrollable datatable component custom UI -- c821226
    • filesFragment.xhtml - filesTable
  • Change sortBy value format in datatable columns -- 1d2bd4c
    • guestbook-responses.xhtml
    • manage-groups.xhtml
    • manage-guestbooks.xhtml
    • manage-templates.xhtml
  • Change PushContext to EventBus for new Push API --
    • IngestMessageBean.java
    • IngestServiceBean.java

@mheppler mheppler changed the title Upgrade to Primefaces 5 Upgrade to PrimeFaces 5 Nov 10, 2015
mheppler added a commit that referenced this issue Nov 10, 2015
@mheppler
Changed sortBy value format in datatable columns for groups, guestboo…
1d2bd4c 
…ks, templates manage pgs, and guestbook response pg. [ref #2731 #2730]
@pdurbin pdurbin modified the milestones: 4.2.3, 4.3 Nov 23, 2015
@sekmiller
Copy link
Contributor

Passing to Leonid for updating push context

@sekmiller sekmiller assigned landreev and unassigned sekmiller Dec 4, 2015
@landreev landreev mentioned this issue Jan 8, 2016
Closed
@kcondon kcondon mentioned this issue Jan 8, 2016
Closed
@landreev landreev assigned kcondon and unassigned landreev Jan 9, 2016
@landreev
Copy link
Contributor

landreev commented Jan 9, 2016

Just moved #2758 into QA. That appears to be the last sub-issue here, so moving this ticket into QA as well.

@kcondon
Copy link
Contributor

kcondon commented Jan 11, 2016

Ingest is working now, closing.

@kcondon kcondon closed this as completed Jan 11, 2016
@pdurbin pdurbin mentioned this issue Jan 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
4.2.3
Development

No branches or pull requests
5 participants
@pdurbin @mheppler @landreev @sekmiller @kcondon