Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "View All" button for files on the dataset page #2705

Closed
pdurbin opened this issue Oct 28, 2015 · 9 comments
Closed

Add "View All" button for files on the dataset page #2705

pdurbin opened this issue Oct 28, 2015 · 9 comments
Labels
Feature: File Upload & Handling Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@pdurbin
Copy link
Member

pdurbin commented Oct 28, 2015

Now that we're adding scrolling, we'd like to have a "View All" button rather than forcing people to scroll and scroll until they can see all the files.

@pdurbin pdurbin added Type: Feature a feature request Status: Dev labels Oct 28, 2015
@pdurbin pdurbin added this to the 4.2.1 Performance patch milestone Oct 28, 2015
@sekmiller
Copy link
Contributor

Added a prelim version that gets all. Mike will look at styling and/or adding a customizable number of records.

sekmiller added a commit that referenced this issue Oct 28, 2015
@sekmiller
Copy link
Contributor

@mheppler added a Show All link to the footer facet of the files table.

@sekmiller sekmiller assigned mheppler and unassigned sekmiller Oct 28, 2015
@kcondon
Copy link
Contributor

kcondon commented Oct 29, 2015

@mheppler @pdurbin @sekmiller
Scroll bar no longer working. This needs to be restored or show all removed if we're releasing Thursday

Also show all does not show all 1000 files. See Also 1000 Files dataset

@pdurbin
Copy link
Member Author

pdurbin commented Oct 29, 2015

@sekmiller said he'd take a look.

@pdurbin pdurbin assigned sekmiller and unassigned mheppler Oct 29, 2015
@sekmiller
Copy link
Contributor

primefaces/primefaces#685

reported issue to PrimeFaces

@sekmiller
Copy link
Contributor

We decided for the purposes of 4.2.1 to forgo this one

@kcondon
Copy link
Contributor

kcondon commented Oct 29, 2015

OK, view all removed, scroller works, closing.

@kcondon kcondon closed this as completed Oct 29, 2015
@pdurbin
Copy link
Member Author

pdurbin commented Oct 29, 2015

@kcondon and I agreed that since we want this feature in 4.3 we should set the milestone to 4.3 and reopen it, so I'll do that now. Basically, it was deferred for the 4.2.1 release. @sekmiller since you'll be working in this area I'll give this issue to you.

@pdurbin pdurbin modified the milestones: 4.3, 4.2.1 Performance patch Oct 29, 2015
@pdurbin pdurbin assigned sekmiller and unassigned kcondon Oct 29, 2015
@pdurbin pdurbin reopened this Oct 29, 2015
@mercecrosas mercecrosas removed this from the 4.3 milestone Nov 30, 2015
@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Feature: File Upload & Handling labels Jan 28, 2016
@sekmiller sekmiller removed their assignment Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@mheppler
Copy link
Contributor

A new issue, Dataset - File UI Improvements #3404, was created to track the UI improvements related to the files view on the dataset pg. Older feature requests and bug reports like this one will be closed in favor of that new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

6 participants