-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 - Storybook Setup #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtreacy
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
rtreacy
approved these changes
Feb 28, 2023
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
3 - Storybook Setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR configures Storybook to be used in the SPA development. Storybooks allows to render each component individually to develop them without being attached to a page, this allows a better development of the components since they are actually uncoupled from other components or pages.
Storybook also allows an easy setup for accessibility tests with the a11y addon.
For Storybook example purposes the HelloDataverse.tsx component has been edited to have a Header.tsx component. This Header will be edited in the future to really match the Dataverse design but for the moment it serves as an example of how to integrate Storybook in the UI development workflow.
Which issue(s) this PR closes:
Closes #3
Special notes for your reviewer:
Changes
Disclaimer about this console error
You'll see this error message in the console when accessing Storybook.
Stoybook is working on it but still there is no solution for the message, however it shouldn't affect Storybook functionalities
Suggestions on how to test this:
Install
node v19
andnpm v9
.Run
npm install
Run
npm run storybook
and go to http://localhost:6006 to see the Storybook pageRun
npm run test-storybook
to run Storybook testsDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
Hello Dataverse with Header screen If you cannot access the screen please contact melinahernandez@theagilemonkeys.com
Is there a release notes update needed for this change?:
Storybook added to the project
Additional documentation:
Dataverse - SPA Development Strategy