-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
586 dataset terms tab #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it sets the active tab='terms'
… PublishDatasetModal.tsx
thanks @g-saracca , I applied the requested changes 👍 |
g-saracca
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more minor things
…on.tsx container div to within the component
…o EditDatasetTermButton.module.scss )
…e restrictive than the Bootstrap component.
g-saracca
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
g-saracca
reviewed
Feb 18, 2025
src/sections/shared/form/EditCreateCollectionForm/collection-form/useSubmitCollection.ts
Outdated
Show resolved
Hide resolved
g-saracca
approved these changes
Feb 18, 2025
Merging PR - tests are now passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 15
FY25 Sprint 15 (2025-01-15 - 2025-01-29)
FY25 Sprint 16
FY25 Sprint 16 (2025-01-29 - 2025-02-12)
FY25 Sprint 17
FY25 Sprint 17 (2025-02-12 - 2025-02-26)
GREI Re-arch
GREI re-architecture-related
Original size: 10
Size: 10
A percentage of a sprint. 7 hours.
SPA.Q1.3
Dataset Page: Terms Tab
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the Dataset Page Terms Tab in read only mode
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.
Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: