Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: fix: Fix missing parens for (string + string).contains(...) #6094

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Luro02
Copy link
Contributor

@Luro02 Luro02 commented Dec 9, 2024

For the code (string + string).contains(string) will remove the parenthesis which results in string + string.contains(string)

Copy link
Collaborator

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but I think this is something where we need to go through all expressions and check whether they need parentheses. But I can do that as a follow-up PR.

@SirYwell SirYwell merged commit 2cf9fb2 into INRIA:master Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants