Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: doc: add SUPPLY-CHAIN.md #6063

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Conversation

ludvigch
Copy link
Contributor

This PR adds documentation of the changes in #6016 as well as a short description on how to verify the attestations created during a release. I am a bit unsure if the manual verification process is relevant or if it suffices with the simpler method of using GitHub CLI to verify an attestation?

Addressing @monperrus suggestion

Copy link
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some suggestions.

image

Do you know what this hash is for on rekor?

SUPPLY-CHAIN.md Outdated Show resolved Hide resolved
SUPPLY-CHAIN.md Outdated Show resolved Hide resolved
Copy link
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@algomaster99
Copy link
Contributor

@I-Al-Istannen @monperrus ready for merge from my side

@ludvigch ludvigch changed the title WIP doc: add SUPPLY-CHAIN.md review: doc: add SUPPLY-CHAIN.md Nov 13, 2024
@monperrus
Copy link
Collaborator

thanks a lot all.

further refined, will merge when CI is green.

@monperrus monperrus merged commit 12f787a into INRIA:master Nov 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants