doc: fix javadoc in TypeFactory.java #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have two different PRs here (typo and cast). They should be separated in two. |
monperrus
reviewed
Oct 19, 2018
| @@ -282,7 +282,7 @@ public TypeFactory() { | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a reference to a one-dimension array of given type. | |||
There was a problem hiding this comment.
"a one" is correct, see https://www.quora.com/Which-is-correct-a-one-or-an-one
There was a problem hiding this comment.
@monperrus
That's right. Thank you for your careful review!
Cast is in #2688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarQube: Remove this unnecessary cast to "CtElement".