review: refactor(label): remove labelledStatement that was not used

[tdurieux]

The property labelledStatement was always equals to null.

Fix #1381

[monperrus]

What about keeping only the getter getLabelledStatement(), put it @Derived, and look it up dynamically, as done for references?

[tdurieux]

It's nit a so trivial task and this api is buggy since the beginning and nobody complain. I will not spend time on a feature that nobody wants

[monperrus]

I understand, thanks for initiating the PR. @surli could you have a look at this, thanks?

[surli]

@surli could you have a look at this, thanks?

You mean to review this PR or to implement it as a derived property?

[monperrus]

to implement it as a derived property. Thanks,

…

--Martin

[tdurieux]

you can test this

public static void main(String[] args) {
		label2:
		{
			System.out.println("block");
			if (args.length != 0 && args[0].equals("test")) {
				System.out.println("block after break3");
				break label2;
			}
			if (args.length ==1 && args[0].equals("test")) {
				System.out.println("block after break1");
				break label2;
			}
			System.out.println("block after break");
		}
		sw:
		switch ("f") {
		case "f":
			label:
			do {
				System.out.println("do");
				while (true) {
					for (int i = 0; i < 4; i++) {
						System.out.println("for");
						label2:
						{
							System.out.println("test");
							break label2;
						}
						System.out.println("for 1");
					}
					break;
				}
				break;
			} while (true);
			break;
		}
	}

[monperrus]

Add a new interface

I'm not sure about this. To be discussed.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170619.224547-48

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 2.

Change 1

Name	Element
Old	method T spoon.reflect.code.CtContinue::setLabelledStatement(spoon.reflect.code.CtStatement)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

Change 2

Name	Element
Old	method T spoon.reflect.code.CtBreak::setTargetLabel(java.lang.String)
New	method T spoon.reflect.code.CtLabelledFlowBreak::setTargetLabel(java.lang.String) @ spoon.reflect.code.CtBreak
Code	java.method.returnTypeChanged
Description	The return type changed from 'T extends spoon.reflect.code.CtBreak' to 'T extends spoon.reflect.code.CtLabelledFlowBreak'.
Breaking	binary: breaking,

Change 2

Name	Element
Old	method T spoon.reflect.code.CtBreak::setTargetLabel(java.lang.String)
New	method T spoon.reflect.code.CtLabelledFlowBreak::setTargetLabel(java.lang.String) @ spoon.reflect.code.CtBreak
Code	java.method.movedToSuperClass
Description	The method used to be declared in class 'spoon.reflect.code.CtBreak' but is now declared in superclass 'spoon.reflect.code.CtLabelledFlowBreak'.
Breaking	binary: equivalent,

Change 2

Name	Element
Old	method T spoon.reflect.code.CtBreak::setTargetLabel(java.lang.String)
New	method T spoon.reflect.code.CtLabelledFlowBreak::setTargetLabel(java.lang.String) @ spoon.reflect.code.CtBreak
Code	java.generics.formalTypeParameterChanged
Description	The formal type parameter changed from 'T extends spoon.reflect.code.CtBreak' to 'T extends spoon.reflect.code.CtLabelledFlowBreak'.
Breaking	binary: non_breaking,

[monperrus]

thanks @tdurieux @surli