Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error computing correlation #54

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix error computing correlation #54

merged 2 commits into from
Nov 28, 2023

Conversation

didi-hou
Copy link
Collaborator

  • Deleted the earlier testing print code lines
  • Added warning message and skip the computation of the cross-correlation in a population when there are less than 2 neurons firing because of a very small value being assigned to the parameter scale_down_to
  • Reran the notebook

@didi-hou didi-hou added bug Something isn't working code improvement Improve the code written labels Nov 27, 2023
@didi-hou didi-hou requested a review from shimoura November 27, 2023 15:57
@shimoura shimoura merged commit 7110623 into INM-6:master Nov 28, 2023
@didi-hou didi-hou deleted the Fix_error_computing_correlation branch November 30, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimoura shimoura shimoura approved these changes

Assignees

@shimoura shimoura

@didi-hou didi-hou

Labels
bug Something isn't working code improvement Improve the code written
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didi-hou @shimoura