EBRAINS-specific changes, reformatting of code structure #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from each other, adds option to specify y_limits
ebrains-specific adaptations of the workflow
…o file (for testing usage without hashes)
…es redundancy in code
Refactor class structure
|
Reviewed offline. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes to the code necessary to comply with the newly implemented scheme of loading data by hashes (started by @jarsi ). Additionally, the structure of the code is altered to better utilize class functionalities, remove redundancies and (hopefully) make the code more legible. Some new features are also added, such as the drawing of vertical/horizontal lines. The documentation is still incomplete and needs to be worked on at a later point in time.
For the review, it would be ideal if you could test whether this version allows you to plot your data on EBRAINS.